[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

Fri Jan 3 09:37:51 PST 2020

ajpaverd added a comment.

In D65761#1772076 <https://reviews.llvm.org/D65761#1772076>, @dmajor wrote:

> Well, this patch specifically has code (even a test) that `nocf_check` prevents CFG, so it looks like the intent was there, it's just that there isn't a way to get that attribute onto functions from cpp in a CFG/non-CET world.

Apologies for the delayed reply! This code was indeed reusing `nocf_check`, but I now think it would be better to use a separate attribute for Control Flow Guard. Please see the proposed improvement at D72167: Add support for __declspec(guard(nocf)) <https://reviews.llvm.org/D72167>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65761/new/

https://reviews.llvm.org/D65761