[PATCH] D72028: [CodeGen] Emit conj/conjf/confjl libcalls as fneg instructions if possible.

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 31 09:34:37 PST 2019


craig.topper marked an inline comment as done.
craig.topper added inline comments.


================
Comment at: clang/test/CodeGen/complex-libcalls.c:115-118
+// NO__ERRNO-NOT: .conj
+// NO__ERRNO-NOT: @conj
+// HAS_ERRNO-NOT: .conj
+// HAS_ERRNO-NOT: @conj
----------------
spatel wrote:
> Could we use positive matches for "fneg" here rather than NOT lines? If so, then do we need the new test file?
All of the CHECK lines are in the declaration part of the file after the function body. They aren’t checking the call site code. I could add new functions for the conj calls and check them earlier?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72028/new/

https://reviews.llvm.org/D72028





More information about the cfe-commits mailing list