[PATCH] D72010: [CodeGen] Use CreateFNeg in buildFMulAdd

[Craig Topper via Phabricator via cfe-commits]

craig.topper marked an inline comment as done.
craig.topper added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3350
+    MulOp0 = Builder.CreateFNeg(MulOp0, "neg");
+  if (negAdd)
+    Addend = Builder.CreateFNeg(Addend, "neg");
----------------
I removed the 'else' here because logically it didn't make sense that whether we looked at negAdd should be dependent on negMul being false. The assert at the beginning of the function still assures they are mutex. But the code shouldn't need that assumption.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72010/new/

https://reviews.llvm.org/D72010