[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

Kelvin Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 30 10:43:35 PST 2019


kkwli0 added a comment.

In D71969#1798224 <https://reviews.llvm.org/D71969#1798224>, @jdoerfert wrote:

> Is there a reason not to put this check right next to the one that issues `err_omp_section_length_negative`. SemaExpr.cpp +4668


It is a good idea to group the checking together however this check is specific for the depend clause.  The map clause allows the zero-length array section.  Isn't it better to keep it in ActOnOpenMPDependClause?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71969/new/

https://reviews.llvm.org/D71969





More information about the cfe-commits mailing list