[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

Mon Dec 30 08:04:02 PST 2019

JonasToth added a comment.

There are many comments not marked as done. could you please do that with addressed issues? It is hard to otherwise see whats still left.

================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:110
+           "making it const")
+          << MemberVariable; // FIXME: Add fix-it hint to MemberVariable
+    }
----------------
vingeldal wrote:
> JonasToth wrote:
> > missing `return`?
> No, one of the below matchers may also be valid, in case we have a non-const member variable which  is also a pointer or reference to non-const data.
I see. Please add a `FALLTHROUGH` comment or the like, as it breaks the pattern a lot and is not obvious from local code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70265/new/

https://reviews.llvm.org/D70265