[PATCH] D71842: Allow newlines in AST Matchers in clang-query files
Dmitri Gribenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 30 07:26:03 PST 2019
gribozavr2 added inline comments.
================
Comment at: clang/include/clang/ASTMatchers/Dynamic/Parser.h:167
static llvm::Optional<DynTypedMatcher>
- parseMatcherExpression(StringRef MatcherCode, Sema *S,
- const NamedValueMap *NamedValues,
- Diagnostics *Error);
+ parseMatcherExpression(StringRef &MatcherCode, Sema *S,
+ const NamedValueMap *NamedValues, Diagnostics *Error);
----------------
Sorry for the late review comment, but I'd really appreciate if you could update the doc comments to explain why MatcherCode is taken by reference, and how it is mutated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71842/new/
https://reviews.llvm.org/D71842
More information about the cfe-commits
mailing list