[PATCH] D71982: [docs] Update path to clang-tools-extra

[Alexander Lanin via Phabricator via cfe-commits]

AlexanderLanin updated this revision to Diff 235577.
AlexanderLanin added a comment.

Hi,
I don't see the error message you mentioned anywhere, but I'm gonna assume it involves the number of surrounding lines. Here is another attempt with

> git show HEAD -U999999 > mypatch.patch



---

Source of problem:
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface tells me to use

> git format-patch -U999999 @ {u}

But then upload fails:

> Diff Parse Exception: Expected a hunk header, like 'Index: /path/to/file.ext' (svn), 'Property changes on: /path/to/file.ext' (svn properties), 'commit 59bcc3ad6775562f845953cf01624225' (git show), 'diff --git' (git diff), '--- filename' (unified diff), or 'diff -r' (hg diff or patch).
> 
>           1885        for more information.</p>
>           1886    
>           1887    </div>
>           1888    </body>
>           1889    </html>
>   >>>     1890   -- 
>           1891   2.24.1.windows.2
>           1892   

https://llvm.org/docs/GettingStarted.html#sending-patches just casually mentions git show and git format-patch without telling anything about options to be used.

Assuming 'git show HEAD -U999999' is the one and only correct way? 'git diff HEAD~1 -U999999' seems to work ok also.
However 'git format-patch' doesn't work as mentioned above. At least for me with git version 2.24.1.windows.2


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71982/new/

https://reviews.llvm.org/D71982

Files:
  clang-tools-extra/docs/clang-include-fixer.rst
  clang-tools-extra/docs/clang-tidy/Contributing.rst
  clang-tools-extra/docs/pp-trace.rst
  clang/www/hacking.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71982.235577.patch
Type: text/x-patch
Size: 15347 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191230/6491c71d/attachment-0001.bin>