[PATCH] D57662: [clang-tidy] Parallelize clang-tidy-diff.py

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

In D57662#1797607 <https://reviews.llvm.org/D57662#1797607>, @derek wrote:

> @zinovy.nis @alexfh @JonasToth @MyDeveloperDay
>
> Hi folks, please correct me if I'm wrong but it appears that an effect of this change is that this script will no longer exit non-zero if `clang-tidy` discovers any errors, which was the previous functionality with `sys.exit(subprocess.call(' '.join(command), shell=True))`. As a result, when we upgraded a project to LLVM 9 our CI began having false-positives, as we relied on the exit code of this script to indicate success/failure. Would it be possible to restore that functionality? I'd be happy to provide a patch.


Yeah, that would be good to restore. `run-clang-tidy.py` is parallelized and does fail properly (95% sure about that xD), so in doubt you can check that script as well.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57662/new/

https://reviews.llvm.org/D57662