[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

Sylvestre Ledru via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 28 09:39:56 PST 2019


sylvestre.ledru added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:411
    *
+   cppcoreguidelines-avoid-non-const-global-variables
+
----------------
It should not be there. It won't be referenced on the list.

If you are uncomfortable setting a severity, leave it empty but it should clearly move above, not on the toctree 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70265/new/

https://reviews.llvm.org/D70265





More information about the cfe-commits mailing list