[PATCH] D71842: Allow newlines in AST Matchers in clang-query files
Stephen Kelly via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 26 09:10:23 PST 2019
steveire marked 9 inline comments as done.
steveire added inline comments.
================
Comment at: clang-tools-extra/clang-query/Query.cpp:111
+ }
+ int maxLength = firstLine.size();
std::string prefixText = "Matcher: ";
----------------
aaron.ballman wrote:
> `MaxLength` and perhaps this type should be `unsigned` or `size_t` rather than `int` to avoid the unnecessary type conversion?
This is where `auto` makes most sense, but I made it `unsigned` instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71842/new/
https://reviews.llvm.org/D71842
More information about the cfe-commits
mailing list