[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

Tue Dec 24 07:27:07 PST 2019

aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.

Thank you for this!

There's some missing test coverage for the changes to the clang-tidy check and for the new matcher. Also, the new matcher should be registered in `clang\lib\ASTMatchers\Dynamic\Registry.cpp` (in alphabetical order). Oh, and you should also run `clang\docs\tools\dump_ast_matchers.py` to regenerate the AST matcher documentation.

================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4300

+/// Matches selection statements with initializer
+///
----------------
Missing a full stop at the end of the sentence.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71846/new/

https://reviews.llvm.org/D71846