[PATCH] D71848: Allow the discovery of Android NDK's triple-prefixed binaries.

Brian Ledger via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 23 14:42:05 PST 2019


brianpl created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
brianpl added a reviewer: jyknight.
brianpl updated this revision to Diff 235182.
brianpl added a comment.

Fix a typo.


Currently, tool discovery checks for a tool with its target triple as a
prefix. Unfortunately, the triple it uses is canonicalized, and may
contain the Android platform numbers as a suffix. This prevents matching
of the binaries in the LLVM bin directory of the Android NDK.

This CL adds checks during discovery that will match the canonical
Android NDK triples. The matcher will work with vendor "unknown", and at
any level platform.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71848

Files:
  clang/lib/Driver/Driver.cpp
  clang/test/Driver/android-triple-version.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71848.235182.patch
Type: text/x-patch
Size: 7810 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191223/cca8eb17/attachment-0001.bin>


More information about the cfe-commits mailing list