[PATCH] D71686: Fix false positive in magic number checker

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D71686#1794053 <https://reviews.llvm.org/D71686#1794053>, @0x8000-0000 wrote:

> My take: this change fixes a user-reported bug, and does not cause any known regressions. I think we should integrate this.


I sort of wonder whether we want to document this as a blessed approach to silencing the warning. I'm not certain if it's too obtuse or not, but I notice the check has no documented ways to silence the diagnostic aside from using the correct kind of magic number or adding it to a list of excluded magic numbers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71686/new/

https://reviews.llvm.org/D71686