[PATCH] D59520: [WebAssembly] Address review comments on r352930

Sat Dec 21 00:06:07 PST 2019

sunfish marked 10 inline comments as done.
sunfish added a comment.

I apologize for the extraordinary delays here; at long last, I've now addressed your feedback.

================
Comment at: lib/Sema/SemaDeclAttr.cpp:5781-5783
+Sema::mergeImportNameAttr(Decl *D, SourceRange Range,
+                          StringRef Name,
+                          unsigned AttrSpellingListIndex) {
----------------
aaron.ballman wrote:
> I wonder if we want to generalize this with a template (for the attribute type) if we could generalize the diagnostic text a bit more (or add an additional parameter for it)?
The diagnostic name is now generalized, but it seems awkward to pass around the numbers to pick which variant of the string to use, so I didn't implement this yet.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59520/new/

https://reviews.llvm.org/D59520