[PATCH] D70689: [analyzer] Fix SARIF column locations

Joe Ranieri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 20 13:37:33 PST 2019


jranieri-grammatech marked 4 inline comments as done.
jranieri-grammatech added inline comments.


================
Comment at: clang/test/Analysis/diagnostics/sarif-multi-diagnostic-test.c:35-36
+{
+  int løçål = 0;
+  /* ☃ */ return 1 / løçål; // expected-warning {{Division by zero}}
+}
----------------
aaron.ballman wrote:
> What file encoding is used by this file (and is there a BOM)? Have you tried this test on multiple platforms by any chance?
The file is encoded in UTF-8 without a BOM. I have not tried the test on other platforms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70689/new/

https://reviews.llvm.org/D70689





More information about the cfe-commits mailing list