[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

LGTM! Yeah, please update the ASCII-art, it's great and every checker should have it.



================
Comment at: clang/docs/analyzer/checkers.rst:1341
+
+Fuchsia Checkers.
+
----------------
Maybe explain what `Fuchsia` is so that people don't wonder if they should turn it on? (:


================
Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:344
+
+ProgramStateRef FuchsiaHandleChecker::evalAssume(ProgramStateRef State,
+                                                 SVal Cond,
----------------
Let's add a high-level comment about what's going on here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70470/new/

https://reviews.llvm.org/D70470