[PATCH] D71769: [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 20 09:10:02 PST 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2f209ccfbe5e: [clang-format] C# formatting a class with inheritance followed by an attributeā¦ (authored by MyDeveloperDay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71769/new/
https://reviews.llvm.org/D71769
Files:
clang/lib/Format/UnwrappedLineParser.cpp
clang/unittests/Format/FormatTestCSharp.cpp
Index: clang/unittests/Format/FormatTestCSharp.cpp
===================================================================
--- clang/unittests/Format/FormatTestCSharp.cpp
+++ clang/unittests/Format/FormatTestCSharp.cpp
@@ -316,6 +316,27 @@
" }\n"
"}\n",
Style);
+
+ verifyFormat("public A : Base\n"
+ "{\n"
+ "}\n"
+ "[Test]\n"
+ "public Foo()\n"
+ "{\n"
+ "}\n",
+ Style);
+
+ verifyFormat("namespace\n"
+ "{\n"
+ "public A : Base\n"
+ "{\n"
+ "}\n"
+ "[Test]\n"
+ "public Foo()\n"
+ "{\n"
+ "}\n"
+ "}\n",
+ Style);
}
TEST_F(FormatTestCSharp, CSharpSpaceBefore) {
Index: clang/lib/Format/UnwrappedLineParser.cpp
===================================================================
--- clang/lib/Format/UnwrappedLineParser.cpp
+++ clang/lib/Format/UnwrappedLineParser.cpp
@@ -466,7 +466,7 @@
(NextTok->is(tok::semi) &&
(!ExpectClassBody || LBraceStack.size() != 1)) ||
(NextTok->isBinaryOperator() && !NextIsObjCMethod);
- if (NextTok->is(tok::l_square)) {
+ if (!Style.isCSharp() && NextTok->is(tok::l_square)) {
// We can have an array subscript after a braced init
// list, but C++11 attributes are expected after blocks.
NextTok = Tokens->getNextToken();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71769.234916.patch
Type: text/x-patch
Size: 1553 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191220/e6ea01a7/attachment.bin>
More information about the cfe-commits
mailing list