[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 20 07:38:30 PST 2019


yaxunl added a comment.

In D71726#1791904 <https://reviews.llvm.org/D71726#1791904>, @jfb wrote:

> This generally seems fine. Does it work on most backends? I want to make sure it doesn't fail in backends :)


For x86_64, amdgcn, aarch64, armv7, mips64, it is translated to cmpxchg by AtomicExpandPass and backends did codegen successfully.

For hexagon, riscv32, it is translated to call of `__atomic_fetch_add_4` for fadd float. This is concerning. Probably we need to add `__atomic_fetch_{add|sub}_{f16|f32|f64}` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71726/new/

https://reviews.llvm.org/D71726





More information about the cfe-commits mailing list