[PATCH] D69876: Allow output constraints on "asm goto"

[Bill Wendling via Phabricator via cfe-commits]

void added inline comments.


================
Comment at: clang/docs/LanguageExtensions.rst:1275
+It's important to note that outputs are valid only on the "fallthrough" branch.
+For example, the value assigned to `y` is not valid in the above `err` block.
+
----------------
nickdesaulniers wrote:
> Would you mind removing the `above` in this sentence. I initially parsed this as `the block above err`, which is not correct.
I changed it.


================
Comment at: clang/test/Sema/asm-goto.cpp:35
+  // expected-error at +1 {{cannot jump from this asm goto statement to one of its possible targets}}
+  asm goto("jmp %l0;" ::::bar);
+    // expected-error at +1 {{cannot jump from this indirect goto statement to one of its possible targets}}
----------------
nickdesaulniers wrote:
> what's going on with the indentation?
Not sure. I blame emacs. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69876/new/

https://reviews.llvm.org/D69876