[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

[Nathan Ridge via Phabricator via cfe-commits]

nridge marked an inline comment as done.
nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp:418
+  EXPECT_THAT(*Result,
+              AllOf(WithName("S<0>"), WithKind(SymbolKind::Struct), Parents()));
 }
----------------
kadircet wrote:
> what about making use of template pattern in case of invalid instantiations?
> 
> as type hierarchy tries to provide information regarding `bases` and `children`, I think it is more important to show those instead of template instantiation arguments.
Is there a way to query a `ClassTemplateSpecializationDecl` for whether instantiating its base specifier failed?

Or, should we fall back on the template pattern any time `bases()` is empty?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71533/new/

https://reviews.llvm.org/D71533