[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

[Pierre Habouzit via Phabricator via cfe-commits]

MadCoder marked an inline comment as done.
MadCoder added inline comments.


================
Comment at: clang/test/CodeGenObjC/direct-method.m:196
+ at implementation Foo (Cat)
+// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"(
+- (int)directMethodInCategory {
----------------
aprantl wrote:
> MadCoder wrote:
> > this may be questionable as a chosen mangling. it's exactly what dynamic dispatch does, but because a direct method cannot have clashes on the same class, this extra namespacing is not useful and is likely making the life of debuggers harder for expression evaluation.
> > 
> > @aprantl should I generate `@"\01-[Foo directMethodInCategory]"` instead? if yes I'd rather do it in this review
> @teemperor implemented the LLDB support. I would assume that changing it to Foo without the category will be necessary for LLDB to find it. @teemperor Can you add an LLDB test for this scenario?
that was my expectation as well, let me update the code to do so then :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71694/new/

https://reviews.llvm.org/D71694