[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

Pierre Habouzit via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 19 12:53:04 PST 2019


MadCoder marked an inline comment as done.
MadCoder added inline comments.


================
Comment at: clang/lib/AST/DeclObjC.cpp:963
     if (ObjCInterfaceDecl *IFD = ImplD->getClassInterface()) {
-      if (ObjCMethodDecl *MD = IFD->getMethod(getSelector(),
-                                              isInstanceMethod()))
+      // When the container is the principal @implementation,
+      // the canonical Decl is either in an @interface, or in an extension.
----------------
aprantl wrote:
> What does "principal" mean here?
primary sorry, will fix


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71694/new/

https://reviews.llvm.org/D71694





More information about the cfe-commits mailing list