[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

[Adrian Prantl via Phabricator via cfe-commits]

aprantl added inline comments.


================
Comment at: clang/lib/AST/DeclObjC.cpp:963
     if (ObjCInterfaceDecl *IFD = ImplD->getClassInterface()) {
-      if (ObjCMethodDecl *MD = IFD->getMethod(getSelector(),
-                                              isInstanceMethod()))
+      // When the container is the principal @implementation,
+      // the canonical Decl is either in an @interface, or in an extension.
----------------
What does "principal" mean here?


================
Comment at: clang/lib/AST/DeclObjC.cpp:966
+      //
+      // So when we don't find it in the principal @interface,
+      // sift through extensions too.
----------------
Does principal mean the ObjCInterfaceDecl of ImplD? Should we say that instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71694/new/

https://reviews.llvm.org/D71694