[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 19 10:13:18 PST 2019


nickdesaulniers added inline comments.


================
Comment at: clang/lib/Analysis/UninitializedValues.cpp:856
   if (!as->isAsmGoto())
     return;
 
----------------
nickdesaulniers wrote:
> nickdesaulniers wrote:
> > Should we mark the vals `MayUninitialized` here, rather than below? Then I think we can remove the `isAsmGoto` check you added in `getUninitUse`?
> Bumping comment.
Ah, I see this was added in https://reviews.llvm.org/D69876.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71314/new/

https://reviews.llvm.org/D71314





More information about the cfe-commits mailing list