[PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 18 13:03:15 PST 2019


rnk planned changes to this revision.
rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: clang/include/clang/AST/ASTContext.h:653
   template <typename NodeT> DynTypedNodeList getParents(const NodeT &Node) {
     return getParents(ast_type_traits::DynTypedNode::create(Node));
   }
----------------
Turns out this only worked for me locally because of delayed template parsing. I will have to think harder about how to preserve the API while not requiring complete types here. I could make an overload set, but I worry it will be inconveniently large.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71313/new/

https://reviews.llvm.org/D71313





More information about the cfe-commits mailing list