[PATCH] D71650: [AST] Fix compilation with GCC < 8 for MinGW
Martin Storsjö via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 18 10:56:16 PST 2019
mstorsjo added a comment.
In D71650#1789897 <https://reviews.llvm.org/D71650#1789897>, @rjmccall wrote:
> Wow, that's novel. Please add a comment explaining that this is a compiler workaround, but otherwise LGTM.
The post-patch form doesn't look that odd to me (and we wouldn't want one comment for every one of the existing enums that already are outside of the structs where they are used for bitfield sizes), but do you think a comment is warranted here on this one?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71650/new/
https://reviews.llvm.org/D71650
More information about the cfe-commits
mailing list