[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 18 09:46:27 PST 2019


ABataev added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9244
+llvm::Function *
+CGOpenMPRuntime::getUserDefinedMapperFunc(const OMPDeclareMapperDecl *D) {
+  auto I = UDMMap.find(D);
----------------
lildmh wrote:
> ABataev wrote:
> > `getOrEmitUserDefinedMapperFunc`?
> I guess `getUserDefinedMapperFunc` is a better name? Because the user uses this function to get the mapper function. Emitting a mapper function is a side effect.
I meant something like `getOrCreate...` but it is up to you.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67833/new/

https://reviews.llvm.org/D67833





More information about the cfe-commits mailing list