[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 18 07:30:11 PST 2019
ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/clangd/AST.cpp:305
+ llvm::raw_string_ostream OS(Result);
+ if (auto *TD = QT->getAsTagDecl())
+ OS << getQualification(CurContext.getParentASTContext(), &CurContext, TD,
----------------
Why not use `explicitTargetReferences` here? This should handle typedefs (and potentially other things) as well.
I'm not sure we can tests those, as `auto` might have all typedefs stripped of, though
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71652/new/
https://reviews.llvm.org/D71652
More information about the cfe-commits
mailing list