[PATCH] D69223: WDocumentation: Implement the \anchor.
Dmitri Gribenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 18 05:27:28 PST 2019
gribozavr2 added a comment.
LGTM, feel free to push.
================
Comment at: clang/lib/AST/TextNodeDumper.cpp:493
+ case comments::InlineCommandComment::RenderAnchor:
+ OS << " RenderAnchor";
+ break;
----------------
Mordante wrote:
> Mordante wrote:
> > gribozavr2 wrote:
> > > Please add a test for this one to clang/test/Index/comment-to-html-xml-conversion.cpp (search for RenderEmphasized in that file).
> > I already added a test to `clang/test/Index/comment-to-html-xml-conversion.cpp`. I forgot to add a test to `clang/test/AST/ast-dump-comment.cpp`, is this the file you meant?
> @gribozavr2 In case you missed the question above, could you have a look at the question?
Sorry, I probably missed your edit to `clang/test/Index/comment-to-html-xml-conversion.cpp` when typing that comment. `ast-dump-comment.cpp` is not as extensive, so I'm not concerned about having to add the test there. If you want to -- feel free, but I think that is optional.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69223/new/
https://reviews.llvm.org/D69223
More information about the cfe-commits
mailing list