[PATCH] D71644: [clangd] Heuristically resolve dependent call through smart pointer type
Nathan Ridge via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 17 20:39:02 PST 2019
nridge marked an inline comment as done.
nridge added inline comments.
================
Comment at: clang-tools-extra/clangd/FindTarget.cpp:116
+ // smart pointer type.
+ ASTContext *Ctx = hackyFindASTContext(T);
+ if (!Ctx)
----------------
I don't intend for this function to be in the final patch.
Rather, I'm wondering: am I missing some obvious general way to recover the `ASTContext` from a `Type` (or a `Stmt`)?
If not, I think we'll need to modify `targetDecl()`, `allTargetDecls()`, `findExplicitReferences()` etc. to have their callers pass in an `ASTContext`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71644/new/
https://reviews.llvm.org/D71644
More information about the cfe-commits
mailing list