[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 17 16:09:03 PST 2019


ABataev added a comment.



In D70258#1788825 <https://reviews.llvm.org/D70258#1788825>, @rjmccall wrote:

> So it's never that OpenMP has things that need to be finalized before exiting (e.g. if something in frontend-emitted code throws an exception), it's just that OpenMP might need to generate its own control flow that breaks through arbitrary scopes in the frontend?
>
> I would really hope that the OpenMP implementation in Clang would've used Clang's cleanup stack rather than inventing its own mechanism.


John, current implementation completely relies on Clang's cleanup stack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70258/new/

https://reviews.llvm.org/D70258





More information about the cfe-commits mailing list