[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

Sergej Jaskiewicz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 17 15:00:51 PST 2019


broadwaylamb added a comment.

LGTM



================
Comment at: clang/cmake/caches/CrossWinToARMLinux.cmake:88-91
+set(LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXXABI  OFF CACHE BOOL "")
+set(LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXX     OFF CACHE BOOL "")
+set(LIBCXX_LINK_TESTS_WITH_SHARED_LIBCXX        OFF CACHE BOOL "")
+set(LIBCXX_LINK_TESTS_WITH_SHARED_LIBCXXABI     OFF CACHE BOOL "")
----------------
These options haven't yet made it into the upstream, maybe it's better remove them for now and add them later when they're stabilized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71625/new/

https://reviews.llvm.org/D71625





More information about the cfe-commits mailing list