[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

Thomas Preud'homme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 17 13:46:21 PST 2019


thopre added a subscriber: nemanjai.
thopre added a comment.
Herald added a subscriber: wuzish.

In D71408#1787959 <https://reviews.llvm.org/D71408#1787959>, @jdenny wrote:

> This breaks the lit test suite.  `llvm/utils/lit/tests/shtest-format.py` needs to be updated for the removed tests.


This is embarrassing. Thanks @nemanjai for fixing this. I did run the tests and remember having one FAIL which I could reproduce without the patch applied. I presume ninja check-all includes those 2 tests so I'm not sure how I missed it. On a related note, I used to receive mail notification when one of my commit would make a buildbot fail but don't anymore. Is there a way to register for those mail notification?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71408/new/

https://reviews.llvm.org/D71408





More information about the cfe-commits mailing list