[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)
Philip Reames via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 17 12:23:25 PST 2019
reames added a comment.
Specifically on the revised patch, I remain confused by the need for multiple subtypes. The need for fragments *between* the potentially fused instructions doesn't make sense to me. What I was expecting to see was the following:
BoundaryAlign w/target=the branch fragment
.. some possibly empty sequence of fragments (i.e. the test/cmp/etc..) ...
the branch fragment
a new data fragment if the branch fragment was a DF
(i.e. a single BounaryAlign fragment which aligns a payload which is defined as "next fragment to target fragment inclusive".)
To be specific, I'd expect to see the following for an example fused sequence:
1. BoundaryAlign w/Target = 3
2. DataFragment containing TEST RAX, RAX
3. RelaxeableFragment containing JNE symbo
Why do we need anything between the two fragments of the fused pair?
(As a reminder, I am new to this code. If I'm missing the obvious, please just point it out.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70157/new/
https://reviews.llvm.org/D70157
More information about the cfe-commits
mailing list