[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

In D70258#1788396 <https://reviews.llvm.org/D70258#1788396>, @jdoerfert wrote:

> In D70258#1788305 <https://reviews.llvm.org/D70258#1788305>, @rjmccall wrote:
>
> > Introducing an IRBuilder-level finalization stack sounds like it's going to be a huge mess if your goal is to plug this into other frontends.
>
>
> While I get that you don't want to review this, I would really like to understand why you think this would become a mess.


I guess it depends on what you're expecting to be able to achieve with this stack.  Frontends have their own notion of what needs to be finalized and what can trigger control flow.  If your finalization stack is purely for the convenience of your internal IR-generation, it's fine.  If the need for a finalizer can cross the emission of arbitrary frontend code, or if your code needs to emit branches that might cross arbitrary frontend "scope" boundaries, you're going to be in trouble.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70258/new/

https://reviews.llvm.org/D70258