[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 17 11:07:26 PST 2019


rjmccall resigned from this revision.
rjmccall added a comment.

I opposed the creation of this library on these terms in the first place, so I'm pretty sure I'm not on the hook to review it.  Introducing an IRBuilder-level finalization stack sounds like it's going to be a huge mess if your goal is to plug this into other frontends.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70258/new/

https://reviews.llvm.org/D70258





More information about the cfe-commits mailing list