[PATCH] D71598: [clangd] Filter implicit references from index while renaming

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 17 06:49:24 PST 2019


ilya-biryukov added a comment.

If we go with the solution proposed by @hokein, it looks like using the current patch is an improvement of what we have now.
One big issue with the adding a new ref kind/ref modifier is that it requires modifications to Kythe-based index implementation, something that cannot be done as easily as landing this patch.

WDYT about landing something similar to this patch for now and discussing the possibilities of fixing it by storing enough information in the references later?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71598/new/

https://reviews.llvm.org/D71598





More information about the cfe-commits mailing list