[PATCH] D71543: [clangd] Fix handling of inline/anon namespaces and names of deduced types in hover

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/Hover.cpp:372
+    T.print(OS, Policy);
+    OS.flush();
+  }
----------------
NIT: is flush redundant? I believe it's called in destructor


================
Comment at: clang-tools-extra/clangd/Hover.cpp:432
+    }();
+    HI = getHoverContents(*Deduced, D, AST.getASTContext(), Index);
   } else if (auto M = locateMacroAt(SourceLocationBeg, AST.getPreprocessor())) {
----------------
Is this the only callsite of `getHoverContents` that we are changin?
We could just move the logic that computes `D` into the `getHoverContents`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71543/new/

https://reviews.llvm.org/D71543