[PATCH] D71586: [clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 17 01:54:54 PST 2019
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
+1, please add a unit test instead.
We prefer to keep the number of lit tests in clangd minimal. They're mostly testing the LSP layer and other things which are hard to unit-test. `-fimplicit-modules` does not seem to be one of these things.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71586/new/
https://reviews.llvm.org/D71586
More information about the cfe-commits
mailing list