[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

Hal Finkel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 16 22:08:51 PST 2019


hfinkel added a comment.

In D71241#1786959 <https://reviews.llvm.org/D71241#1786959>, @jdoerfert wrote:

> In D71241#1786530 <https://reviews.llvm.org/D71241#1786530>, @ABataev wrote:
>
> > Most probably, we can use this solution without adding a new expression. `DeclRefExpr` class can contain 2 decls: FoundDecl and the Decl being used. You can use FoundDecl to point to the original function and used decl to point to the function being called in this context. But at first, we need to be sure that we can handle all corner cases correctly.
>
>
> What new expression are you talking about?


To be clear, I believe he's talking about the new expression that I proposed we add in order to represent this kind of call. If that's not needed, and we can use the FoundDecl/Decl pair for that purpose, that should also be considered.

> This solution already does point to both declarations, as shown here: https://reviews.llvm.org/D71241#1782504


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71241/new/

https://reviews.llvm.org/D71241





More information about the cfe-commits mailing list