[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip
Dan Gohman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 16 14:20:38 PST 2019
sunfish added inline comments.
================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:725
TOut.emitExportName(WasmSym, ExportName);
+ Out.EmitSymbolAttribute(WasmSym, MCSA_NoDeadStrip);
}
----------------
It feels like this is a little inconsistent. If `export_name` doesn't automatically imply `used` in LLVM IR or .o files, why does it do so in .s files?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71493/new/
https://reviews.llvm.org/D71493
More information about the cfe-commits
mailing list