[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns
Thomas Lively via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 16 11:49:12 PST 2019
tlively marked an inline comment as done.
tlively added inline comments.
================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:189
+ setOperationAction(Op, T, Legal);
+ }
+
----------------
aheejin wrote:
> Just curious, what gets assigned we don't do this? I thought the default value was `Legal`..
When we don't do this, we get a sequence that does a compare and a select. You're right that the default is `Legal` for most things, but not for higher-level instructions like these.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71500/new/
https://reviews.llvm.org/D71500
More information about the cfe-commits
mailing list