[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

Mon Dec 16 10:34:50 PST 2019

kparzysz added inline comments.

================
Comment at: clang/test/Driver/hexagon-toolchain-elf.c:560
+// CHECK082-NOT:      "-march=hexagon"
+// CHECK082-NOT:      "-mcpu=hexagon"
----------------
kparzysz wrote:
> I don't think there will ever be `"-mcpu=hexagon"` (including the quotation marks). Maybe this should just check for any `-march` and `-mcpu`.
This is still wrong.  Assume that we are passing `-mcpu=hexagonv60` to lld. The options will show up with quotation marks, and so it will be `"-mcpu=hexagonv60"`.  The testcase is checking for `"-mcpu"` which will not match `"-mcpu=hexagonv60"`, and the testcase will pass even though it shouldn't.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70919/new/

https://reviews.llvm.org/D70919