[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context
Gabor Marton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 16 07:48:16 PST 2019
martong marked an inline comment as done.
martong added inline comments.
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:252
+ QualType Ty = FD->getFriendType()->getType().getCanonicalType();
+ if (isa<ElaboratedType>(Ty))
+ Ty = cast<ElaboratedType>(Ty)->getNamedType();
----------------
a_sidorin wrote:
> I wonder if ElaboratedType can be a canonical type because it is only a sugar type itself. Do we need to handle this case?
You are right, I removed this case. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71020/new/
https://reviews.llvm.org/D71020
More information about the cfe-commits
mailing list