[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

Mon Dec 16 07:21:58 PST 2019

erichkeane added a comment.

In D71467#1784398 <https://reviews.llvm.org/D71467#1784398>, @erichkeane wrote:

> In D71467#1784338 <https://reviews.llvm.org/D71467#1784338>, @craig.topper wrote:
>
> > In D71467#1784286 <https://reviews.llvm.org/D71467#1784286>, @rjmccall wrote:
> >
> > > The bug with `__builtin_isless` should be a really easy fix; the builtin just needs to be flagged as having custom type-checking, and then we need to make sure we do appropriate promotions on the arguments (but we probably do).
> >
> >
> > I think I convinced @erichkeane to look at it on Monday.
>
>
> Everything but fpclassify is pretty trivial, I just needed to write a test but needed to go home. I'll commit that Monday when I get to it. Fpclassify will take a touch longer since the int arguments need to be dealt with, but that shouldn't be more than a little work.

I did the compare operators that didn't work right, and will do a separate patch for the fp-classification type ones: f02d6dd6c7afc08f871a623c0411f2d77ed6acf8 <https://reviews.llvm.org/rGf02d6dd6c7afc08f871a623c0411f2d77ed6acf8>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71467/new/

https://reviews.llvm.org/D71467