[PATCH] D61549: Fix use of 'is' operator for comparison

Mon Dec 16 07:21:57 PST 2019

tambre added a comment.

In D61549#1785369 <https://reviews.llvm.org/D61549#1785369>, @Jim wrote:

> @j-carl Could you give a Python 3.8 syntax reference for this change.

This is not a language change in Python 3.8. AFAICT, the behaviour of `is` has been the same as long as Python has been in use.
CPython 3.8 only added the warning for incorrect usages where the result is always `False`, as in this case.

It's unclear to me why @j-carl thinks this change might resolve this. This behaviour should be consistent across at least Python 2.7–3.8.

I'm also unsure why this has yet to be reviewed and how might I get someone to do that.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61549/new/

https://reviews.llvm.org/D61549