[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

[Aleksei Sidorin via Phabricator via cfe-commits]

a_sidorin added a comment.

Hi Gabor,
I have an inline comment for the patch. Otherwise, looks good.



================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:252
+  QualType Ty = FD->getFriendType()->getType().getCanonicalType();
+  if (isa<ElaboratedType>(Ty))
+    Ty = cast<ElaboratedType>(Ty)->getNamedType();
----------------
I wonder if ElaboratedType can be a canonical type because it is only a sugar type itself. Do we need to handle this case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71020/new/

https://reviews.llvm.org/D71020