[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

Fri Dec 13 15:54:35 PST 2019

erichkeane added a comment.

In D71467#1784338 <https://reviews.llvm.org/D71467#1784338>, @craig.topper wrote:

> In D71467#1784286 <https://reviews.llvm.org/D71467#1784286>, @rjmccall wrote:
>
> > The bug with `__builtin_isless` should be a really easy fix; the builtin just needs to be flagged as having custom type-checking, and then we need to make sure we do appropriate promotions on the arguments (but we probably do).
>
>
> I think I convinced @erichkeane to look at it on Monday.

Everything but fpclassify is pretty trivial, I just needed to write a test but needed to go home. I'll commit that Monday when I get to it. Fpclassify will take a touch longer since the int arguments need to be dealt with, but that shouldn't be more than a little work.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71467/new/

https://reviews.llvm.org/D71467