[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument
Akira Hatanaka via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 13 13:00:15 PST 2019
ahatanak marked an inline comment as done.
ahatanak added inline comments.
================
Comment at: clang/docs/AutomaticReferenceCounting.rst:1866
+When a block pointer type is converted to type ``id``, ``Block_copy`` is called.
+This is necessary because a block allocated on the stack won't get copied to the
----------------
rjmccall wrote:
> "to a non-block pointer type (such as ``id``)", please. Otherwise looks good. I didn't realize that this conversion behavior wasn't documented at all, so thank you for adding it.
I thought it was documented too and searched for it, but couldn't find it anywhere in the ARC doc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71431/new/
https://reviews.llvm.org/D71431
More information about the cfe-commits
mailing list