[PATCH] D71082: Allow system header to provide their own implementation of some builtin

[Eli Friedman via Phabricator via cfe-commits]

efriedma added inline comments.


================
Comment at: clang/lib/AST/Decl.cpp:3019
+    if (SL.isValid())
+      return SM.isInSystemHeader(SL);
+  }
----------------
I'm a little concerned about this; we're subtly changing our generated code based on the "system-headerness" of the definition.  We generally avoid depending on this for anything other than warnings. It could lead to weird results with preprocessed source, or if someone specifies their include paths incorrectly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71082/new/

https://reviews.llvm.org/D71082